Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR

David Howells wrote:

Hugh Dickins <[email protected]> wrote:

Remove use of FIRST_USER_PGD_NR from sys_mincore: it's inconsistent (no
other syscall refers to it), unnecessary (sys_mincore loops over vmas
further down) and incorrect (misses user addresses in ARM's first pgd).

You should make it use FIRST_USER_ADDRESS instead. This check allows NULL
pointers and suchlike to be weeded out before having to take the semaphore.

I'm not sure whether it is worth keeping the singular special
case here to slightly speed up what would probably be a bug in
a userspace program.

--
SUSE Labs, Novell Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
    • From: Hugh Dickins <[email protected]>

• References:
  • [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
    • From: Hugh Dickins <[email protected]>
  • [PATCH 1/6] freepgt2: free_pgtables from FIRST_USER_ADDRESS
    • From: Hugh Dickins <[email protected]>
  • Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
    • From: David Howells <[email protected]>

• Prev by Date: Re: non-free firmware in kernel modules, aggregation and unclear copyright notice.
• Next by Date: Re: [Fwd: Re: connector is missing in 2.6.12-rc2-mm1]
• Previous by thread: Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
• Next by thread: Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]