Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR

Hugh Dickins <[email protected]> wrote:

> 
> Remove use of FIRST_USER_PGD_NR from sys_mincore: it's inconsistent (no
> other syscall refers to it), unnecessary (sys_mincore loops over vmas
> further down) and incorrect (misses user addresses in ARM's first pgd).

You should make it use FIRST_USER_ADDRESS instead. This check allows NULL
pointers and suchlike to be weeded out before having to take the semaphore.

Also, just because no other syscall refers to such a value doesn't mean that
this one shouldn't and that others shouldn't.

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
    • From: Nick Piggin <[email protected]>

• References:
  • [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
    • From: Hugh Dickins <[email protected]>
  • [PATCH 1/6] freepgt2: free_pgtables from FIRST_USER_ADDRESS
    • From: Hugh Dickins <[email protected]>

• Prev by Date: Re: Kernel SCM saga..
• Next by Date: Re: 2.6.12-rc2 in_atomic() picks up preempt_disable()
• Previous by thread: [PATCH 5/6] freepgt2: arch FIRST_USER_ADDRESS 0
• Next by thread: Re: [PATCH 2/6] freepgt2: sys_mincore ignore FIRST_USER_PGD_NR
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]