On Thu, 2005-03-31 at 17:31 -0800, Andrew Morton wrote:
> >
> > struct cb_id
> > {
> > __u32 idx;
> > __u32 val;
> > };
>
> It is vital that all data structures be skilfully commented - they are the
> key to understanding the code. Why the struct exists, which actor passes
> it to which other actor(s), whether the data structure is communicated with
> userspace, what other data structures it is aggregated with or linked to,
> locking rules, etc.
It is described in Documentation/connector/connector.txt.
Should it also be placed here?
> > struct cn_msg
> > {
>
> Please do
>
> struct cn_msg {
Neither structure declaration should have opening brace on the new
string?
> >
> > #define CN_CBQ_NAMELEN 32
>
> Commentary?
Maximum allowed callback name - name will be truncated if
it exceeds that limit.
I will place this doc in the code.
--
Evgeniy Polyakov
Crash is better than data corruption -- Arthur Grabowski
Attachment:
signature.asc
Description: This is a digitally signed message part
- Follow-Ups:
- Re: connector.h
- From: Andrew Morton <[email protected]>
- Re: connector.h
- References:
- connector.h
- From: Andrew Morton <[email protected]>
- connector.h
- Prev by Date: Re: connector.c
- Next by Date: Re: Industry db benchmark result on recent 2.6 kernels
- Previous by thread: connector.h
- Next by thread: Re: connector.h
- Index(es):
 |