Thanks for confirming. Are you guys interested in this kind of leaks? I have
a list of about a hundred generated by our tool. -yichen
> -----Original Message-----
> From: Herbert Xu [mailto:[email protected]]
> Sent: Wednesday, March 23, 2005 3:31 AM
> To: Yichen Xie
> Cc: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]
> Subject: Re: memory leak in net/sched/ipt.c?
>
> Yichen Xie <[email protected]> wrote:
> > Is the memory block allocated on line 315 leaked every time
> > tcp_ipt_dump is called?
>
> It seems to be. This patch should free it.
>
> Signed-off-by: Herbert Xu <[email protected]>
>
> BTW, please report networking bugs to [email protected].
>
> Thanks,
> --
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <[email protected]>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> --
> ===== net/sched/ipt.c 1.14 vs edited =====
> --- 1.14/net/sched/ipt.c 2005-02-07 16:39:40 +11:00
> +++ edited/net/sched/ipt.c 2005-03-23 22:28:13 +11:00
> @@ -284,10 +284,12 @@
> tm.lastuse = jiffies_to_clock_t(jiffies - p->tm.lastuse);
> tm.expires = jiffies_to_clock_t(p->tm.expires);
> RTA_PUT(skb, TCA_IPT_TM, sizeof (tm), &tm);
> + kfree(t);
> return skb->len;
>
> rtattr_failure:
> skb_trim(skb, b - skb->data);
> + kfree(t);
> return -1;
> }
>
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
