On Tue, 27 Nov 2007 13:03:29 +0800 "rae l" <[email protected]> wrote: > -static void hexdump(unsigned char *buf, unsigned int len) > +static inline void hexdump(unsigned char *buf, unsigned int len) > { > - while (len--) > - printk("%02x", *buf++); > - > - printk("\n"); > + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET, > + 16, 1, > + buf, len, false); > } uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes down to 19,701. inlining is almost always wrong. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Re: [PATCH 1/2] crypto test: use print_hex_dump from <linux/kernel.h>
- From: Herbert Xu <[email protected]>
- [PATCH] [RESEND] crypto test: use print_hex_dump from <linux/kernel.h> instead
- From: Denis Cheng <[email protected]>
- Re: [PATCH] [RESEND] crypto test: use print_hex_dump from <linux/kernel.h> instead
- From: Joe Perches <[email protected]>
- Re: [PATCH] [RESEND] crypto test: use print_hex_dump from <linux/kernel.h> instead
- From: Herbert Xu <[email protected]>
- [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead
- From: Denis Cheng <[email protected]>
- Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead
- From: Richard Knutsson <[email protected]>
- Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead
- From: "rae l" <[email protected]>
- Re: [PATCH 1/2] crypto test: use print_hex_dump from <linux/kernel.h>
- Prev by Date: Re: Avoid creating P2P prefetch window for expansion ROMs
- Next by Date: Re: Small System Paging Problem - OOM-killer goes nuts
- Previous by thread: Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead
- Next by thread: Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead
- Index(es):
 |