Re: [PATCH 1/2] crypto test: use print_hex_dump from <linux/kernel.h>

On Mon, Nov 26, 2007 at 03:13:02PM +0800, Denis Cheng wrote:
> these utilities implemented in lib/hexdump.c are more handy, please use this.
> 
> Cc: Randy Dunlap <[email protected]>
> Signed-off-by: Denis Cheng <[email protected]>

OK this is pretty nice.  But you just missed out because the
GCM patches that just went in added more hexdump uses :)

So could you please refresh your patch against the latest cryptodev
tree? Please also clamp those long lines to 80 characters.

On an unrelated note, lib/hexdump.c should not print 8-bit text
even though they pass the is_print test.  They just turn up as
crap on Unicode terminals.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- [PATCH] [RESEND] crypto test: use print_hex_dump from <linux/kernel.h> instead
  - From: Denis Cheng <[email protected]>

References:
- [PATCH 1/2] crypto test: use print_hex_dump from <linux/kernel.h>
  - From: Denis Cheng <[email protected]>

Prev by Date: Re: [PATCH 05/27] rename open_namei() to open_pathname()
Next by Date: Re: Question regarding naming scheme (HP Jornada 6XX/7XX)
Previous by thread: [PATCH 1/2] crypto test: use print_hex_dump from <linux/kernel.h>
Next by thread: [PATCH] [RESEND] crypto test: use print_hex_dump from <linux/kernel.h> instead
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]