On Sun, 15 Jul 2007 23:59:03 GMT
Linux Kernel Mailing List <[email protected]> wrote:
> Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=7c9e3c2e3b0437d10a09b77769baf325b94aa436
> Commit: 7c9e3c2e3b0437d10a09b77769baf325b94aa436
> Parent: 53b67950026ee642b43615f46df22ec3d36b4a53
> Author: Al Viro <[email protected]>
> AuthorDate: Sun Jul 15 20:59:31 2007 +0100
> Committer: Linus Torvalds <[email protected]>
> CommitDate: Sun Jul 15 16:40:51 2007 -0700
>
> wrong order of arguments of ->readdir()
>
> Shows how many people are testing coda - the bug had been there for 5 years
> and results of stepping on it are not subtle.
>
> Signed-off-by: Al Viro <[email protected]>
> Signed-off-by: Linus Torvalds <[email protected]>
> ---
> fs/coda/dir.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/coda/dir.c b/fs/coda/dir.c
> index 9ddf5ed..898a86d 100644
> --- a/fs/coda/dir.c
> +++ b/fs/coda/dir.c
> @@ -470,7 +470,7 @@ int coda_readdir(struct file *coda_file, void *dirent, filldir_t filldir)
>
> ret = -ENOENT;
> if (!IS_DEADDIR(host_inode)) {
> - ret = host_file->f_op->readdir(host_file, filldir, dirent);
> + ret = host_file->f_op->readdir(host_file, dirent, filldir);
> file_accessed(host_file);
> }
> }
Today is not being a good day.
This bug was already fixed. The following mistakes were made:
a) Jan's patch was misleadingly titled "coda: avoid lockdep warning in
coda_readdir"
b) Jan's patch had no changelog
c) Jen's patch was not cc'ed to any mailing list
d) Al's patch was not sent to the maintainer. Nor to me. Nor was it
staged in any tree which I can get at so that I could inform people of
the upcoming conflict/duplication/etc.
Guys (and I mean all guys): things are really shit at present. Please try
to do better.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
