Re: [PATCH] try parent numa_node at first before using default

On Thu, 12 Jul 2007 10:59:53 -0700,
Yinghai Lu <[email protected]> wrote:

> @@ -1285,8 +1290,11 @@ int device_move(struct device *dev, struct device *new_parent)
>  	dev->parent = new_parent;
>  	if (old_parent)
>  		klist_remove(&dev->knode_parent);
> -	if (new_parent)
> +	if (new_parent) {
>  		klist_add_tail(&dev->knode_parent, &new_parent->klist_children);
> +		set_dev_node(dev, dev_to_node(new_parent));
> +	}
> +
>  	if (!dev->class)
>  		goto out_put;
>  	error = device_move_class_links(dev, old_parent, new_parent);

You're not correctly undoing the changes if the last function fails.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] try parent numa_node at first before using default v2
    • From: Yinghai Lu <[email protected]>

• References:
  • Re: [PATCH 1/5] try parent numa_node at first before using default
    • From: Stefan Richter <[email protected]>
  • Re: [PATCH 1/5] try parent numa_node at first before using default
    • From: Cornelia Huck <[email protected]>
  • [PATCH] try parent numa_node at first before using default
    • From: Yinghai Lu <[email protected]>

• Prev by Date: Re: [PATCH] PCI: Move prototypes for EXPORT_SYMBOL functions to include/linux/pci.h
• Next by Date: Re: [2.6 patch] re-add required code to include/asm-v850/unistd.h
• Previous by thread: Re: [PATCH] try parent numa_node at first before using default
• Next by thread: [PATCH] try parent numa_node at first before using default v2
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]