Re: [PATCH] slab: ensure cache_alloc_refill terminates

On Wed, 21 Feb 2007, Pekka J Enberg wrote:

> +              */
> +             BUG_ON(slabp->inuse < 0 || slabp->inuse >= cachep->num);
> +
>               while (slabp->inuse < cachep->num && batchcount--) {

On 2/21/07, Christoph Lameter <[email protected]> wrote:

I think you only need to check for <0. If slabp->inuse > cachep->num then
the loop will not be taken.

...and batchcount is not decremented and we're effectively in an
infinite loop. Or am I missing something here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] slab: ensure cache_alloc_refill terminates
    • From: Christoph Lameter <[email protected]>

• References:
  • [PATCH] slab: ensure cache_alloc_refill terminates
    • From: Pekka J Enberg <[email protected]>
  • Re: [PATCH] slab: ensure cache_alloc_refill terminates
    • From: Christoph Lameter <[email protected]>

• Prev by Date: Re: [PATCH 0/6] KVM userspace interface updates for 2.6.21
• Next by Date: Re: [PATCH] update ctime and mtime for mmaped write
• Previous by thread: Re: [PATCH] slab: ensure cache_alloc_refill terminates
• Next by thread: Re: [PATCH] slab: ensure cache_alloc_refill terminates
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]