Re: [patch 03/18] Dont leak NT bit into next task

On Wednesday 21 February 2007 02:49, Greg KH wrote:

>  /* frame pointer must be last for get_wchan */
> -#define SAVE_CONTEXT    "pushq %%rbp ; movq %%rsi,%%rbp\n\t"
> -#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp\n\t"
> +#define SAVE_CONTEXT    "pushf ; pushq %%rbp ; movq %%rsi,%%rbp\n\t"
> +#define RESTORE_CONTEXT "movq %%rbp,%%rsi ; popq %%rbp ; popf\t"

No idea if this is a problem or not, but you forgot a \n after popf.

-- 
Giuseppe "Oblomov" Bilotta

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch 03/18] Dont leak NT bit into next task
    • From: Adrian Bunk <[email protected]>
  • Re: [patch 03/18] Dont leak NT bit into next task
    • From: Chuck Ebbert <[email protected]>
  • Re: [patch 03/18] Dont leak NT bit into next task
    • From: Jan Engelhardt <[email protected]>

• References:
  • [patch 03/18] Dont leak NT bit into next task
    • From: Greg KH <[email protected]>

• Prev by Date: [S390] prevent softirqs if delay is called disabled
• Next by Date: [S390] fix non-smp compile.
• Previous by thread: [patch 03/18] Dont leak NT bit into next task
• Next by thread: Re: [patch 03/18] Dont leak NT bit into next task
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]