Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR

On Mon, Feb 19, 2007 at 06:04:45PM +0300, Oleg Nesterov wrote:
> On 02/19, Jarek Poplawski wrote:
> >
> > On Mon, Feb 19, 2007 at 03:03:53PM +0300, Oleg Nesterov wrote:
> > > On 02/19, Jarek Poplawski wrote:
> > ...
> > > kfree() doesn't check WORK_STRUCT_PENDING, it makes no
> > > difference if it is set or not when work->func() runs.
> > 
> > It looks like it's to be checked before kfree.
> 
> Here,
> 	br_add_if:
...

I meant "it's to be checked", if it's used by a program.
The name: work_release seems to tell the work function
could signal, when it doesn't need a structure no more.
But br_if.c doesn't seem to use this infomation now,
so there should be no difference after changing to
"without _NAR". This change will limit some potential
changes in the future, but if it's not used by anybody
than the simpler api is a gain.

Jarek P.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>

• References:
  • [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Jarek Poplawski <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Jarek Poplawski <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: 2.6.18.7 OK, 2.6.19.4 & 2.6.20 & 2.6.20.1 NOT
• Next by Date: [PATCH] free pages in remove_arg_zero()
• Previous by thread: Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
• Next by thread: Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]