Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR

On Mon, Feb 19, 2007 at 03:03:53PM +0300, Oleg Nesterov wrote:
> On 02/19, Jarek Poplawski wrote:
...
> kfree() doesn't check WORK_STRUCT_PENDING, it makes no
> difference if it is set or not when work->func() runs.

It looks like it's to be checked before kfree.

> > So, even if this functionality isn't used now, I can't
> > see what changing this could buy.
> 
> We are going to kill _NAR stuff.

If you're sure nobody uses this in any way then it
seems the right decision.

Jarek P.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>

• References:
  • [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Jarek Poplawski <[email protected]>
  • Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
    • From: Oleg Nesterov <[email protected]>

• Prev by Date: Re: [PATCH 09/44 take 2] [UBI] debug unit header
• Next by Date: Re: 2.6.16.32 stuck in generic_file_aio_write()
• Previous by thread: Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
• Next by thread: Re: [PATCH 1/3] net/bridge/br_if.c: don't use _WORK_NAR
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]