Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

Hello.

Andrew Morton wrote:

+			status = *(volatile u32 *)up->port.private_data;

It distresses me that this patch uses a variable which this patch
doesn't initialise anywhere.  It isn't complete.

   I assume this gets passed via early_serial_setup(). Marc?

The sub-driver code whch sets up this field shuld be included in the
patch, no?

   Hardly so, this code (not a subdriver) resides under arch/mips/ I think.

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
    • From: Marc St-Jean <[email protected]>
  • Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: bloc_til_ready in tty driver
• Next by Date: Re: [Xen-devel] Re: [patch 14/21] Xen-paravirt: Add XEN config options and disable unsupported config options.
• Previous by thread: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
• Next by thread: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]