Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master

On Thu, 15 Feb 2007 13:26:29 -0600
Marc St-Jean <[email protected]> wrote:

> +			status = *(volatile u32 *)up->port.private_data;

It distresses me that this patch uses a variable which this patch
doesn't initialise anywhere.  It isn't complete.

The sub-driver code whch sets up this field shuld be included in the
patch, no?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
    • From: Sergei Shtylyov <[email protected]>

• References:
  • [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
    • From: Marc St-Jean <[email protected]>

• Prev by Date: Re: GPL vs non-GPL device drivers
• Next by Date: Re: sparse chokes on arch/i386/kernel/i8253.c (was: 2.6.20-mm1)
• Previous by thread: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
• Next by thread: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git master
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]