Re: [git patches] libata updates (mostly fixes)

Jeff Garzik wrote:

--- a/include/linux/ata.h
+++ b/include/linux/ata.h
@@ -352,7 +352,7 @@ static inline int ata_drive_40wire(const u16 *dev_id)
 {
 	if (ata_id_major_version(dev_id) >= 5 && ata_id_is_sata(dev_id))
 		return 0;	/* SATA */
-	if (dev_id[93] & 0x4000)
+	if ((dev_id[93] & 0xE000) == 0x6000)
 		return 0;	/* 80 wire */
 	return 1;
 }

A thought: it seems to me that the major version check should be moved into ata_id_is_sata().

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • [PATCH] libata: test major version in ata_id_is_sata()
    • From: Tejun Heo <[email protected]>

• References:
  • [git patches] libata updates (mostly fixes)
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [PATCH 9/11] Panic delay fix
• Next by Date: Re: GPL vs non-GPL device drivers
• Previous by thread: [git patches] libata updates (mostly fixes)
• Next by thread: [PATCH] libata: test major version in ata_id_is_sata()
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]