Re: [PATCH 9/11] Panic delay fix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pavel Machek wrote:

You know it is ugly. Alan demonstrated it even hurts performance, but
being ugly is the main problem.

No argument with that. Well, we're ok with dropping it. Actually, reverting the entire set of udelay changes now seems wise. The same bug that happened with i8042 can happen with any hardware device driven by the VM in passthrough mode - potentially USB or IDE CDROM or direct SCSI.

Since that is per-device and not global, a global udelay disable really is broken in that case, and recompiling individual C files or modules for passthrough vs. non-passthrough is not the answer.

So Rusty, Chris, Jeremy, any objections to killing udelay() and friends in paravirt-ops? It would simplify things a bit. The only thing we lose is a slightly faster boot time in the 100% emulated device case. I'm ok with losing that. Even the PIT fast paths don't use udelay, so I don't think we care for runtime performance at all.

Zach
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux