Re: [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler

On Fri, 2007-02-09 at 10:31 +0100, Andi Kleen wrote:
> On Friday 09 February 2007 10:14, Rusty Russell wrote:
> 
> > +unhandled_paravirt:
> > +	/* Nothing wanted us: try to die with dignity (impossible trap). */ 
> > +	movl	$0x1F, %edx
> > +	pushl	$0
> > +	jmp	early_fault
> 
> Please print a real message with early_printk

If we make it thought early_fault, this will do just that.

Given this is a "never happens" situation, however... if you're actually
under Xen or lguest, you won't make it that far (lguest, at least, will
kill you on the cr2 load in early_fault, but it doesn't matter because
we won't get anywhere with early_printk anyway).

Actually, if we did BUG() here at least lguest would print something...
I wonder what Xen would do...

Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler
    • From: Jeremy Fitzhardinge <[email protected]>

• References:
  • [PATCH 0/10] lguest
    • From: Rusty Russell <[email protected]>
  • [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler
    • From: Rusty Russell <[email protected]>
  • Re: [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler
    • From: Andi Kleen <[email protected]>

• Prev by Date: Re: [PATCH 6/10] lguest code: the little linux hypervisor.
• Next by Date: Re: [PATCH 6/10] lguest code: the little linux hypervisor.
• Previous by thread: Re: [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler
• Next by thread: Re: [PATCH 1/10] lguest: Don't rely on last-linked fallthru when no paravirt handler
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]