Re: [PATCH] mm: remove global locks from mm/highmem.c

On Fri, Feb 02, 2007 at 01:24:40PM -0600, Matt Mackall wrote:
> On Fri, Feb 02, 2007 at 12:05:11PM +0000, Christoph Hellwig wrote:
> > On Wed, Jan 31, 2007 at 02:22:24PM +1100, David Chinner wrote:
> > > > Yup.  Even better, use clear_highpage().
> > > 
> > > For even more goodness, clearmem_highpage_flush() does exactly
> > > the right thing for partial page zeroing ;)
> > 
> > Note that there are tons of places in buffer.c that could use
> > clearmem_highpage_flush().  See the so far untested patch below:
> > 
> 
> You probably need s/memclear/clearmem/g..

Not needed - as usual, the code is right and the comments
are wrong. ;)

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: Peter Zijlstra <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: "Martin J. Bligh" <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: "Martin J. Bligh" <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: David Chinner <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: David Chinner <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: Christoph Hellwig <[email protected]>
  • Re: [PATCH] mm: remove global locks from mm/highmem.c
    • From: Matt Mackall <[email protected]>

• Prev by Date: Re: [PATCH] mm: remove global locks from mm/highmem.c
• Next by Date: Re: [PATCH 2 of 4] Introduce i386 fibril scheduling
• Previous by thread: Re: [PATCH] mm: remove global locks from mm/highmem.c
• Next by thread: Re: [PATCH] mm: remove global locks from mm/highmem.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]