Hi,
On Tue, Jan 30, 2007 at 08:36:32PM +0800, Wang Zhenyu wrote:
> ok, just see the AGP tables bits definition for intel_i815_driver,
> /* Intel registers */
> #define INTEL_APSIZE 0xb4
> #define INTEL_ATTBASE 0xb8
> #define INTEL_AGPCTRL 0xb0
> ...
> And this could explain why your patch can make X come back to live on
> i815, as default suspend saves 64bytes. We need suspend func to handle
> this, but for now mainline intel integrated gfx, this's not needed.
> Would you send out a cleanup patch later?
OK, I just spent an entire evening on this tiresome procedure
of trying, not quite successful, machine killed, rebooting, adapting,
trying, hang, ...
My conclusions:
- never forget about stup@#$@#$% PCI posting! (hours wasted
due to register values NOT restored after resume...)
- those 3 registers above are not sufficient, since AGP status is
completely broken, not even such basic things as 4x mode or sideband
addressing bits get restored, so these need proper care as well.
- backing up about 10 registers properly (all those that have
different state after resume) makes it work fine without going
over the whole extended PCI register range needlessly
I'm going to spend more time on this, so...:
Questions (in order of fine-grainedness):
- is intel-agp the right place to reinit such things, or should
something be changed in a more global way? Would other drivers
be responsible for that instead? x.org?
- should we have infrastructure available which records AGP state
in all its nicety in various variables, with chipset-specific
access functions (AGP mode, memory setup, ...)?
That way we'd be able to implement one chipset-agnostic
suspend/resume, which could be a heavenly thing
considering the amount of different chipsets...
(IOW, we should perhaps focus on maintaining an abstract device state
tracking, not blindly push those I/O instructions out to the
device and forget about actual device state)
- should we just implement a plain'n stupid I/O register array
for each chipset which denotes the registers that need resume
maintenance and also records their pre-suspend values? (DUMB)
- or even (shudder) simply always recover the entire PCI I/O space
no matter which chipset it is?
I really want to get this improved, so any ideas how it should
best be updated to get a nice clean generic suspend/resume functionality
for all chipsets? (at least Intel, or even better for all types)
And it would be very useful to add a generic function for those
repeated agp_bridge->dev->device == PCI_DEVICE_... checks
which takes a PCI ID array input... (inline or real function, doesn't matter).
Thanks!
Andreas Mohr
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
