Re: [patch]cleanup and error reporting for sound/core/init.c

At Fri, 12 Jan 2007 14:49:57 +0100,
Oliver Neukum wrote:
> 
> +	} else {
> +		 if (idx < snd_ecards_limit) {
> +			if (snd_cards_lock & (1 << idx))
> +				err = -EBUSY;	/* invalid */
> +		} else if (idx < SNDRV_CARDS)
> +				snd_ecards_limit = idx + 1; /* increase the limit */
> +			else
> +				err = -ENODEV;

The indent looks strange in the above three lines.
Also, for me it's not much better than before... :)
(all if's are comparisons of idx with other values.)


Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch]cleanup and error reporting for sound/core/init.c
    • From: Oliver Neukum <[email protected]>

• References:
  • [patch]cleanup and error reporting for sound/core/init.c
    • From: Oliver Neukum <[email protected]>

• Prev by Date: Re: 2.6.20-rc4-mm1 md problem
• Next by Date: Re: [PATCH 05/05] Linux Kernel Markers, non optimised architectures
• Previous by thread: [patch]cleanup and error reporting for sound/core/init.c
• Next by thread: Re: [patch]cleanup and error reporting for sound/core/init.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]