Jeff Garzik wrote:
* After your patch, the code explicitly calls pci_request_region() for BARs 0-4, but never for BAR5.
Without checking for failures, I might add.Let's call that regression/obvious bug #4, because the previous code actually CARED if the resource was reserved.
if (legacy_mode & ATA_PORT_PRIMARY)
pci_request_region(pdev, 1, DRV_NAME);
if (legacy_mode & ATA_PORT_SECONDARY)
pci_request_region(pdev, 3, DRV_NAME);
/* If there is a DMA resource, allocate it */
pci_request_region(pdev, 4, DRV_NAME);
I agree this is one way to avoid conflicts! ;-) Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- References:
- Re: Happy New Year (and v2.6.20-rc3 released)
- From: "Alessandro Suardi" <[email protected]>
- Re: Happy New Year (and v2.6.20-rc3 released)
- From: Linus Torvalds <[email protected]>
- Re: Happy New Year (and v2.6.20-rc3 released)
- From: Jeff Garzik <[email protected]>
- [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
- From: Alan <[email protected]>
- Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
- From: Jeff Garzik <[email protected]>
- Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
- From: Alan <[email protected]>
- Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
- From: Jeff Garzik <[email protected]>
- Re: Happy New Year (and v2.6.20-rc3 released)
- Prev by Date: Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
- Next by Date: Re: [PATCH] Open Firmware device tree virtual filesystem
- Previous by thread: Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
- Next by thread: Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))
- Index(es):
 |