Check attachment for the new patch,thanks. BRs Peer Chen -----Original Message----- From: Jeff Garzik [mailto:[email protected]] Sent: Wednesday, November 01, 2006 5:48 PM To: Peer Chen Cc: Arjan van de Ven; [email protected]; [email protected]; Alan Cox Subject: Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c Peer Chen wrote: > Attached the patch cause my mail client always wrap the plain text format. > Check attachment for patch,thanks. Need one more modification: It is the libata policy to prefer use of numeric hexidecimal constants for the PCI device id, rather than always defining a symbol in include/linux/pci_ids.h. The PCI device ID is a single-use "magic number" that is only used in the PCI ID table. Therefore, when your patch changes the hex numbers to constants, it is reversing that policy. Instead, please submit a patch that simply adds more hexidecimal PCI device ids. Jeff ----------------------------------------------------------------------------------- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. -----------------------------------------------------------------------------------
Attachment:
patch.sata_nv
Description: patch.sata_nv
- Follow-Ups:
- References:
- Prev by Date: Re: [patch 1/1] schedule removal of FUTEX_FD
- Next by Date: 2.6.19-rc3-mm1: compilation fails if CONFIG_KEVENT is disabled
- Previous by thread: Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c
- Next by thread: Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c
- Index(es):
 |