Re: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c

Peer Chen wrote:
> Attached the patch cause my mail client always wrap the plain text format.
> Check attachment for patch,thanks.

Need one more modification:

It is the libata policy to prefer use of numeric hexidecimal constants
for the PCI device id, rather than always defining a symbol in
include/linux/pci_ids.h.  The PCI device ID is a single-use "magic
number" that is only used in the PCI ID table.

Therefore, when your patch changes the hex numbers to constants, it is
reversing that policy.

Instead, please submit a patch that simply adds more hexidecimal PCI
device ids.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • RE: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c
    • From: "Peer Chen" <[email protected]>

• Prev by Date: Re: [ckrm-tech] [RFC] Resource Management - Infrastructure choices
• Next by Date: Re: [ckrm-tech] [RFC] Resource Management - Infrastructure choices
• Previous by thread: what lock protects sb->s_flags
• Next by thread: RE: [PATCH 1/2] sata_nv: Add nvidia SATA controllers of MCP67support to sata_nv.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]