Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.

>>>> +	for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) {
>>>
>> Also works without the () around ARRAY_SIZE(..)-1
>
>Sure.  But I don't really trust C precedence (because it is wrong)

Wrong? In mathematics, "a < (b - 1)" also is equivalent to "a < b - 1".

>and having to remember where it is wrong sucks.  Plus in this
>case I really am making it clear that ARRAY_SIZE(..)-1 is the concept
>I want.   If there would any more to the expression that would
>be important.


Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: [email protected] (Eric W. Biederman)

• References:
  • [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Jan Engelhardt <[email protected]>
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: [PATCH 0/8] Avoiding fragmentation with subzone groupings v25
• Next by Date: Re: [patch 29/37] dvb-core: Proper handling ULE SNDU length of 0
• Previous by thread: Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
• Next by thread: Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]