Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.

Jan Engelhardt <[email protected]> writes:

>>> +static struct pid_entry proc_base_stuff[] = {
>>> +	NOD(PROC_TGID_INO, 	"self", S_IFLNK|S_IRWXUGO,
>>> +		&proc_self_inode_operations, NULL, {}),
>>> +	{}
>>> +};
>>
>>We could save a bunch of bytes here.
>>
>>> +	/* Lookup the directory entry */
>>> +	for (p = proc_base_stuff; p->name; p++) {
>>
>>By using ARRAY_SIZE here.
>>
>>> +	for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) {
>>
>>like that does.
>
> Also works without the () around ARRAY_SIZE(..)-1

Sure.  But I don't really trust C precedence (because it is wrong)
and having to remember where it is wrong sucks.  Plus in this
case I really am making it clear that ARRAY_SIZE(..)-1 is the concept
I want.   If there would any more to the expression that would
be important.

Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Jan Engelhardt <[email protected]>

• References:
  • [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: [email protected] (Eric W. Biederman)
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Andrew Morton <[email protected]>
  • Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
    • From: Jan Engelhardt <[email protected]>

• Prev by Date: Re: [PATCH] FRV: Use the generic IRQ stuff
• Next by Date: Re: [PATCH] FRV: do_gettimeofday() should no longer use tickadj
• Previous by thread: Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
• Next by thread: Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]