Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

Shailabh Nagar <[email protected]> wrote:
>
> +/*
> + * Per-task exit data sent from the kernel to user space
> + * is tagged by an id based on grouping of cpus.
> + *
> + * If userspace specifies a non-zero P as the nl_pid field of
> + * the sockaddr_nl structure while binding to a netlink socket,
> + * it will receive exit data from threads that exited on cpus in the range
> + *
> + *    [(P-1)*Y, P*Y-1]
> + *
> + *  where Y = TASKSTATS_CPUS_PER_SET
> + *  i.e. if TASKSTATS_CPUS_PER_SET is 16,
> + *  to listen to data from cpus 0..15, specify P=1
> + *  for cpus 16..32, specify P=2 etc.
> + *
> + *  To listen to data from all cpus, userspace should use P=0
> + */
> +
> +#define TASKSTATS_CPUS_PER_SET	16

The constant is unpleasant.

If we're going to abuse nl_pid then how about we design things so that
nl_pid is treated as two 16-bit words - one word is the start CPU and the
other word is the end cpu?

Or, if a 65536-CPU limit is too scary, make the bottom 8 bits of nl_pid be
the number of CPUS (ie: TASKSTATS_CPUS_PER_SET) and the top 24 bits is the
starting CPU.  

<avoids mentioning nl_pad>

It'd be better to use a cpumask, of course..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>

• References:
  • [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Jay Lan <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Jay Lan <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Andrew Morton <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Jay Lan <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Andrew Morton <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Andrew Morton <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Jay Lan <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Andrew Morton <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Andrew Morton <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Jay Lan <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Andrew Morton <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Jay Lan <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Andrew Morton <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Jay Lan <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Paul Jackson <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: [email protected]
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Paul Jackson <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Andrew Morton <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>
  • Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
    • From: Shailabh Nagar <[email protected]>

• Prev by Date: Re: [PATCH] fix kbuild module names (was: Re: oom-killer problem)
• Next by Date: Re: [PATCH -mm] ide_end_drive_cmd(): avoid instruction pipeline stall
• Previous by thread: Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
• Next by thread: Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]