Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation

On Sun, Feb 26, 2006 at 07:55:18PM +0100, Adrian Bunk wrote:
> On Sun, Feb 26, 2006 at 07:41:16PM +0100, Alessandro Zummo wrote:
> > On Sat, 25 Feb 2006 14:10:25 +0100
> > Adrian Bunk <[email protected]> wrote:
> > 
> > > 
> > > Sounds good, but for generic functions, two adjustments are required:
> > > - move the code to lib/
> > > - remove rtc_ prefixes from the functions
> > 
> >  Moved. I'm not sure about renaming them.. 
> > 
> >  the functions are:
> > 
> > rtc_month_days
> > rtc_time_to_tm
> > rtc_valid_tm
> > rtc_tm_to_time
> > 
> >  I think they make more sense with the rtc prefix
> 
> None of these functions is in any way specicific to RTC drivers.

Doesn't having them take a struct rtc_time (which is different from
struct tm) make them rather RTC specific?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
    • From: Adrian Bunk <[email protected]>

• References:
  • 2.6.16-rc4-mm2
    • From: Andrew Morton <[email protected]>
  • 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
    • From: Adrian Bunk <[email protected]>
  • Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
    • From: Alessandro Zummo <[email protected]>
  • Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
    • From: Adrian Bunk <[email protected]>
  • Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
    • From: Alessandro Zummo <[email protected]>
  • Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
    • From: Adrian Bunk <[email protected]>

• Prev by Date: Re: [PATCH] Convert serial_core oopses to BUG_ON
• Next by Date: Re: OOM-killer too aggressive?
• Previous by thread: Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
• Next by thread: Re: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]