Re: [2.6 patch] i386: always use 4k stacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Bodo Eggert a écrit :
Horst von Brand <[email protected]> wrote:

"With some drawbacks" is the point: It has been determined that the
drawbacks are heavy enough that the 8KiB stack option should go.

Determined by voodoo and wild guessing.

Let's detect the need for 4K stacks: (I hope I found the correct place)

(Maybe the printk should be completely ifdefed, but I'm not sure)


Signed-off-by: Bodo Eggert <[email protected]>

--- 2.6.14/kernel/fork.c.ori    2005-12-21 19:06:24.000000000 +0100
+++ 2.6.14/kernel/fork.c        2005-12-21 19:15:23.000000000 +0100
@@ -168,4 +168,9 @@ static struct task_struct *dup_task_stru
        if (!ti) {
                free_task_struct(tsk);
+               printk(KERN_WARNING, "Can't allocate new task structure"
+#ifndef CONFIG_4KSTACKS
+               ". Maybe you could benefit from 4K stacks.\n"
+#endif
+               "\n");
                return NULL;
        }


This patch is not OK but for i386 architecture.

For example, x86_64 cannot use a 4K stack, it needs a 8KB stack (so a order-1 allocation that may fail)

Eric

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]
  Powered by Linux