On Wed, 2005-11-09 at 22:48 +0000, Anton Altaparmakov wrote:
> Hi Andrew,
>
> The read-only check in inode_update_time() (or file_update_time() as it is
> now in -mm) is unnecessary as the VFS better have done all the read-only
> checks and aborted much earlier in the file write code paths where
> inode/file_update_time() is only called from.
I notice inode_update_time is called from pipe_writev. I don't know how
likely it would be in practice, but wouldn't it be possible to write to
a pipe on a read-only partition? In that case the read-only check still
makes sense.
> (In case you were not following the ntfs discussion, Christoph Hellwig
> agreed that check is unnecessary and can be removed.)
>
> Patch against latest Linus git tree is below, please apply. If you prefer
> a patch on top of Christoph's file_update_time() check please let me
> know...
>
> Best regards,
>
> Anton
--
David Kleikamp
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
