Oops, sorry about the empty message ...
> -static int ext3_writepages_get_block(struct inode *inode, sector_t iblock,
> - struct buffer_head *bh, int create)
> +static int ext3_writepages_get_blocks(struct inode *inode, sector_t iblock,
> + unsigned long max_blocks, struct buffer_head *bh, int create)
> {
> - return ext3_direct_io_get_blocks(inode, iblock, 1, bh, create);
> + return ext3_direct_io_get_blocks(inode, iblock, max_blocks, bh, create);
> }
>
I have a question here, ext3_direct_io_get_blocks use DIO_CREDITS
(EXT3_RESERVE_TRANS_BLOCKS + 32 = ) to reserve the space for
journalling, but it seems based on assumption of one data block update
once a time. Is it sufficent to re-use that routine for multiple block
allocation here? Don't we need something like
ext3_writepage_trans_blocks() here?
Thanks,
Mingming
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
- Follow-Ups:
- Re: [Ext2-devel] [RFC] Adding multiple block allocation
- From: Suparna Bhattacharya <[email protected]>
- Re: [Ext2-devel] [RFC] Adding multiple block allocation
- References:
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: Mingming Cao <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- From: "Stephen C. Tweedie" <[email protected]>
- [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- From: Mingming Cao <[email protected]>
- Re: [RFC][PATCH] Reduce ext3 allocate-with-reservation lock latencies
- From: Lee Revell <[email protected]>
- [RFC] Adding multiple block allocation to current ext3
- From: Mingming Cao <[email protected]>
- Re: [Ext2-devel] [RFC] Adding multiple block allocation
- From: Suparna Bhattacharya <[email protected]>
- Re: ext3 allocate-with-reservation latencies
- Prev by Date: Re: [RFC][PATCH] i386 x86-64 Eliminate Local APIC timer interrupt
- Next by Date: Re: [PATCH 1a/7] dlm: core locking
- Previous by thread: Re: [Ext2-devel] [RFC] Adding multiple block allocation
- Next by thread: Re: [Ext2-devel] [RFC] Adding multiple block allocation
- Index(es):
 |