Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC

* Mikael Pettersson <[email protected]> wrote:

>  > -	jz restore_all
>  > +	jz restore_nocheck
>  >  	testl $IF_MASK,EFLAGS(%esp)     # interrupts off (exception path) ?
>  > -	jz restore_all
>  > +	jz restore_nocheck
>  >  	call preempt_schedule_irq
>  >  	jmp need_resched
>  >  #endif
> 
> Is this sufficient or do we also need the 
> s/restore_all/restore_nocheck/ at around line 553 which was in the 
> first posted patch?

all 3 restore_all->restore_nocheck changes are needed to make the bug 
not trigger. I dont think it's a real fix because whatever is being 
preempted involuntarily, it ought to have a proper kernel stack to begin 
with. I'll do some more debugging.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Ingo Molnar <[email protected]>
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Andrew Morton <[email protected]>
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Ingo Molnar <[email protected]>
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Ingo Molnar <[email protected]>
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Ingo Molnar <[email protected]>
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Mikael Pettersson <[email protected]>

• Prev by Date: Re: clock runs at double speed on x86_64 system w/ATI RS200 chipset (with APIC enabled)
• Next by Date: Re: [patch] inotify for 2.6.11
• Previous by thread: Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
• Next by thread: Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]