Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC

* Ingo Molnar <[email protected]> wrote:

> > this fixed my crashes too.
> 
> spoke too soon - they still trigger even with the patch applied.

the patch below fixes the crash, it was related to CONFIG_PREEMPT.

	Ingo

--
fix entry.S crash with PREEMPT+PAGEALLOC

Signed-off-by: Ingo Molnar <[email protected]>

--- linux/arch/i386/kernel/entry.S.orig
+++ linux/arch/i386/kernel/entry.S
@@ -165,9 +165,9 @@ ENTRY(resume_kernel)
 need_resched:
 	movl TI_flags(%ebp), %ecx	# need_resched set ?
 	testb $_TIF_NEED_RESCHED, %cl
-	jz restore_all
+	jz restore_nocheck
 	testl $IF_MASK,EFLAGS(%esp)     # interrupts off (exception path) ?
-	jz restore_all
+	jz restore_nocheck
 	call preempt_schedule_irq
 	jmp need_resched
 #endif
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Mikael Pettersson <[email protected]>

• References:
  • crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Ingo Molnar <[email protected]>
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Andrew Morton <[email protected]>
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Ingo Molnar <[email protected]>
  • Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
    • From: Ingo Molnar <[email protected]>

• Prev by Date: Re: [PATCH]: Fix get_compat_sigevent()
• Next by Date: Re: [patch] inotify for 2.6.11
• Previous by thread: Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
• Next by thread: Re: crash in entry.S restore_all, 2.6.12-rc2, x86, PAGEALLOC
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]