From: Gui Jianfeng <[email protected]>
Date: Thu, 27 Dec 2007 15:26:46 +0800
> I think the following code in fib6_del_route in the latest kernel is useless.
> 1125 if (fn->leaf == NULL && fn->fn_flags&RTN_TL_ROOT)
> 1126 fn->leaf = &ip6_null_entry;
>
> ip6_null_entry will never be unlinked from fn->leaf now, that is,
> fn->leaf == NULL will never meet.
I think you are right, but if it is true the next block of
code is dead too:
/* If it was last route, expunge its radix tree node */
if (fn->leaf == NULL) {
fn->fn_flags &= ~RTN_RTINFO;
rt6_stats.fib_route_nodes--;
fn = fib6_repair_tree(fn);
}
But I am not completely convinced that all of these lines
of code can be removed :-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
