Re: [PATCH] SH/Dreamcast - add support for GD-Rom device

On Thursday 27 December 2007, Joe Perches wrote:
> On Thu, 2007-12-27 at 16:52 +0000, Adrian McMenamin wrote:
> > This patch adds support for the CD-Rom drive on the SEGA Dreamcast.
>
> Because it was already so close, might as well make it checkpatch clean.

for the 80 col limit, that's up to the author.  if Adrian is happy with it as 
is, that's fine.

> I also added a function gdrom_is_busy() to make a couple of tests
> fit on a single line and perhaps easier to read.

i'd tend to agree it does make it easier to read, however you didnt make it 
inline which means gcc may not inline it which means there's pointless 
overhead of doing a function call.

otherwise, arbitrary breaking on 80 cols actually makes the code harder to 
read for no gain.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

---

• Follow-Ups:
  • Re: [PATCH] SH/Dreamcast - add support for GD-Rom device
    • From: Paul Mundt <[email protected]>

• References:
  • [PATCH] SH/Dreamcast - add support for GD-Rom device
    • From: Adrian McMenamin <[email protected]>
  • Re: [PATCH] SH/Dreamcast - add support for GD-Rom device
    • From: Joe Perches <[email protected]>

• Prev by Date: Re: SLUB sysfs support
• Next by Date: [PATCH] remove val in __do_proc_dointvec
• Previous by thread: Re: [PATCH] SH/Dreamcast - add support for GD-Rom device
• Next by thread: Re: [PATCH] SH/Dreamcast - add support for GD-Rom device
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]