Re: [PATCH 1/3] arch/x86: Use offsetof

Pavel Machek wrote:

diff -u -p a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c
--- a/arch/x86/kernel/vm86_32.c	2007-10-22 11:25:00.000000000 +0200
+++ b/arch/x86/kernel/vm86_32.c	2007-12-26 16:27:15.000000000 +0100
@@ -215,7 +215,9 @@ asmlinkage int sys_vm86old(struct pt_reg
 	ret = -EFAULT;
 	if (tmp)
 		goto out;
-	memset(&info.vm86plus, 0, (int)&info.regs32 - (int)&info.vm86plus);
+	memset(&info.vm86plus, 0,
+	       offsetof(struct kernel_vm86_struct, regs32) -
+	       offsetof(struct kernel_vm86_struct, vm86plus));

I do not think this makes it more readable... (int) -> (char *) would
make it portable and readable, AFAICT.
								Pavel

The right way to do it is:

	memset(&info.vm86plus, 0, sizeof info.vm86plus);

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 1/3] arch/x86: Use offsetof
    • From: Jan Engelhardt <[email protected]>
  • Re: [PATCH 1/3] arch/x86: Use offsetof
    • From: Al Viro <[email protected]>

• References:
  • [PATCH 1/3] arch/x86: Use offsetof
    • From: Julia Lawall <[email protected]>
  • Re: [PATCH 1/3] arch/x86: Use offsetof
    • From: Pavel Machek <[email protected]>

• Prev by Date: Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.
• Next by Date: Re: [PATCH 1/3] arch/x86: Use offsetof
• Previous by thread: Re: [PATCH 1/3] arch/x86: Use offsetof
• Next by thread: Re: [PATCH 1/3] arch/x86: Use offsetof
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]