Re: [PATCH 01/16] introduce vcpu struct

On Friday 21 December 2007 00:33:41 Glauber de Oliveira Costa wrote:
> this patch introduces a vcpu struct for lguest. In upcoming patches,
> more and more fields will be moved from the lguest struct to the vcpu

Hi Glommer,

> +static inline struct lguest *lg_of_vcpu(struct lguest_vcpu *vcpu)
> +{
> +	return container_of((vcpu - vcpu->vcpu_id), struct lguest, vcpus[0]);
> +}

I think this function is a bad idea: it contains implicit UP assumptions which 
aren't obvious to the caller.  vcpu->lg should do the same thing, no?

Rusty,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH 0/16] lguest: introduce vcpu structure
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 01/16] introduce vcpu struct
    • From: Glauber de Oliveira Costa <[email protected]>

• Prev by Date: Re: Testing RAM from userspace / question about memmap= arguments
• Next by Date: Re: [PATCH 02/16] adapt lguest launcher to per-cpuness
• Previous by thread: Re: [PATCH 02/16] adapt lguest launcher to per-cpuness
• Next by thread: Re: [PATCH 0/16] lguest: introduce vcpu structure
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]