Just a style nit...
On Tue, Dec 18, 2007 at 10:01:14AM +1100, Benjamin Herrenschmidt wrote:
> This patch converts users of pci_enable_device_bars() to the new
> pci_enable_device_{io,mem} interface.
>
> The new API fits nicely, except maybe for the QLA case where a bit of
> code re-organization might be a good idea but I prefer sticking to the
> simple patch as I don't have hardware to test on.
>
> I'll also need some feedback on the cs5520 change.
>
> Signed-off-by: Benjamin Herrenschmidt <[email protected]>
....
> /* We must not grab the entire device, it has 'ISA' space in its
> - BARS too and we will freak out other bits of the kernel */
> - if (pci_enable_device_bars(dev, 1<<2)) {
> + * BARS too and we will freak out other bits of the kernel
> + *
> + * pci_enable_device_bars() is going away. I replaced it with
> + * IO only enable for now but I'll need confirmation this is
> + * allright for that device. If not, it will need some kind of
> + * quirk. --BenH.
> + */
This comment doesn't really belong in the code. It should be part of
the commit log or email RFC.
cheers,
grant
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[Index of Archives]
[Kernel Newbies]
[Netfilter]
[Bugtraq]
[Photo]
[Stuff]
[Gimp]
[Yosemite News]
[MIPS Linux]
[ARM Linux]
[Linux Security]
[Linux RAID]
[Video 4 Linux]
[Linux for the blind]
[Linux Resources]
