Correct use of __init and __devinit

Could someone here help settle this argument?

I have written a driver (for the CD Rom on the Sega Dreamcast). I have
marked various initialisation functions - including probe() and the
functions that it, and only it, calls, as __init.

Other developers tell me I should mark them as __devinit.

However I think this is wrong as:

* The CD on the Dreamcast is not and will never be a hotpluggable device

* The Dreamcast is a limited memory device and if marking various
functions as __init helps save memory that is A Good Thing

It has been put to me that while the use case (not hotpluggable) is
correct, it is still better practice to use __devinit

I have built the code with both __init and __devinit and both work, so
there is no issue of practicality as such here.

Adrian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: Correct use of __init and __devinit
    • From: Sam Ravnborg <[email protected]>

• Prev by Date: Re: [PATCH 4/4] usb: libusual: locking cleanup
• Next by Date: [PATCH] powerpc: DBox2 Board Support
• Previous by thread: Re: x86: Increase PCIBIOS_MIN_IO to 0x1500 to fix nForce 4 suspend-to-RAM
• Next by thread: Re: Correct use of __init and __devinit
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]