Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

On Sat, 22 Dec 2007, Jeff Garzik wrote:
> 
> But regardless of problems, enabling should be done globally, not per
> device...

I'm ok with trying the "globally" idea, but it has to be "globally but 
only if absolutely required".

And quite frankly, how do you tell whether it's absolutely required or 
not?

I have an idea: the drivers that really need it will do a "please enable 
MMCONFIG, because I will need it" thing?

Ok?

And then, since we *need* such a "pci_enable_mmconfig()" call anyway, why 
not let the driver give which device it controls too, so that we can print 
out the information (in case the machine then hangs immediately 
afterwards), and perhaps - if it is shown to help - only do the MMCONFIG 
cycles for that particular device?

Sounds like a plan?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Benjamin Herrenschmidt <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Jeff Garzik <[email protected]>

• References:
  • [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Arjan van de Ven <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Jeff Garzik <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Arjan van de Ven <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Linus Torvalds <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Jeff Garzik <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Linus Torvalds <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Jeff Garzik <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Linus Torvalds <[email protected]>
  • Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
    • From: Jeff Garzik <[email protected]>

• Prev by Date: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
• Next by Date: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
• Previous by thread: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
• Next by thread: Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]