Re: [PATCH] SC26XX: New serial driver for SC2681 uarts

On Mon, Dec 03, 2007 at 03:53:17PM -0800, Andrew Morton wrote:
> > +#define READ_SC(p, r)        readb ((p)->membase + RD_##r)
> > +#define WRITE_SC(p, r, v)    writeb ((v), (p)->membase + WR_##r)
> 
> No space before the (.  checkpatch misses this.

Yep, over careful in the special case for the parameters for #define
macros, which have different spacing rules.  This will be fixed in 0.13:

WARNING: no space between function name and open parenthesis '('
#1: FILE: Z45.c:1:
+#define WRITE_SC(p, r, v)    writeb ((v), (p)->membase + WR_##r)

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] SC26XX: New serial driver for SC2681 uarts
    • From: Thomas Bogendoerfer <[email protected]>
  • Re: [PATCH] SC26XX: New serial driver for SC2681 uarts
    • From: Andrew Morton <[email protected]>

• Prev by Date: Re: [patch 1/2] Linux Kernel Markers - Support Multiple Probes
• Next by Date: Re: Major regression on hackbench with SLUB (more numbers)
• Previous by thread: Re: [PATCH] SC26XX: New serial driver for SC2681 uarts
• Next by thread: kobject ->k_name memory leak
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]