Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

[Jens Axboe <jens.axboe@oracle.com>]

On Fri, Dec 21 2007, Adrian McMenamin wrote:
> On Fri, December 21, 2007 2:22 pm, Jens Axboe wrote:
> > On Fri, Dec 21 2007, Adrian McMenamin wrote:
> >> On 21/12/2007, Jens Axboe <jens.axboe@oracle.com> wrote:
> >> >
> >> > Your design is also heavily geared towards there just being a single
> >> > CDROM, I'm assuming this wont be a problem given your hw (it sets a
> >> bad
> >> > example for others to follow though, lots of violations against normal
> >> > programming practice for multiple devices and smp).
> >>
> >>
> >> Yes, because is there only one device and there will only ever be one
> >> device (unless you know of somebody doing Dreamcast hardware
> >> development).
> >>
> >> I understand the point you are making but adding in additional code
> >> would only diminish resource availability or slow performance on a
> >> small machine without actually delivering any better outcomes for
> >> kernel users..
> >>
> >> Is it reaslly necessary?
> >
> > No it's not necessary, it was just a general reflection on how it could
> > have been done more in style with "regular" drivers.
> >
> 
> 
> I have another look at the code, though i am anxious not to add to the
> driver's footprint if it is not bring any real benefit. Let me see if
> there is a way round that.

Don't break your neck over it, it was nothing more than an observation
:-)

BTW, I saw something else - you should always use sector_div() to do
divisions on a sector_t type.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/