Re: [PATCH - SH/Dreamcast] Add support for GD-Rom device

[Jens Axboe <jens.axboe@oracle.com>]

On Fri, Dec 21 2007, Jens Axboe wrote:
> static void gdrom_readdisk_dma(struct work_struct *work)
> {
>         ...
> 
>         read_command = kzalloc(sizeof(struct packet_command), GFP_KERNEL);
>         if (!read_command)
>                 probably just defer the work to some time later
> 
>         spin_lock(&gdrom_lock);
>         while (!list_empty(&gdrom_deferred)) {
>                 req = list_entry(gdrom_deferred.next, struct request, queuelist);
>                 list_del_init(&req->queuelist);
>                 spin_unlock(&gdrom_lock);
> 
>                 ...
> 
>                 spin_lock(&gdrom_lock);
>         };
> 
+         spin_unlock(&gdrom_lock);
>         kfree(read_command);
> }

is missing, of course.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/