Re: [PATCH] constify tables in kernel/sysctl_check.c

>>> Eric W. Biederman <[email protected]> 21.12.07 00:05 >>>
>"Jan Beulich" <[email protected]> writes:
>
>> Remains the question whether it is intended that many, perhaps even
>> large, tables are compiled in without ever having a chance to get used,
>> i.e. whether there shouldn't #ifdef CONFIG_xxx get added.
>
>
>The constification looks good.  The file should be compiled only when
>we have sysctl support.  We use those tables when we call 
>register_sysctl_table.  Which we do a lot.

I understand this. Nevertheless, the tables take 23k on 64-bits, and many
of them are unused when certain subsystems aren't being built (and some
are even architecture specific). The arlan tables are a particularly good
example, but the netfilter ones are pretty big and probably not always
used, too.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH] constify tables in kernel/sysctl_check.c
    • From: [email protected] (Eric W. Biederman)

• References:
  • Re: [PATCH] constify tables in kernel/sysctl_check.c
    • From: [email protected] (Eric W. Biederman)

• Prev by Date: Re: almost daily Kernel oops with 2.6.23.9 - and now 2.6.23.11 as well
• Next by Date: Some Serial Wacom Tablet devices failing to return from Hibernate/Suspend
• Previous by thread: Re: [PATCH] constify tables in kernel/sysctl_check.c
• Next by thread: Re: [PATCH] constify tables in kernel/sysctl_check.c
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]