Re: [RFC] kobject/kset/ktype documentation and example code updated

["Robert P. J. Day" <rpjday@crashcourse.ca>]

On Thu, 20 Dec 2007, Greg KH wrote:

> How about:
> 	- A ktype is the type of object that embeds a kobject.

if i were reading the above for the first time, i would have no idea
what was being embedded where.  "embeds a kobject" where?  what's
being embedded in what?  that sentence doesn't make it clear.  what's
the current definition for a "struct kobject"?

>         Every structure that embeds a kobject needs a corresponding ktype.

and if it does, whose responsibility is it to provide one?  mine?
that's not clear.

> 	  The ktype controls what happens to the kobject when it is
> 	  created and destroyed.

i doubt that.   i wouldn't say that the ktype "controls" what happens,
i would say that it "defines" what happens.  to control suggests
active participation.

rday


========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/