Re: [PATCH] apm_event{,info}_t are userspace types.

On Wed, 2007-12-12 at 02:47 -0800, Andrew Morton wrote:
> On Fri, 30 Nov 2007 15:02:43 -0500 Adam Jackson <[email protected]> wrote:
> > These types define the size of data read from /dev/apm_bios.  They
> > should not be hidden behind #ifdef __KERNEL__.
> 
> Missing info: what are the consequences of this fix?  What id broken when
> it it not applied?

The X server won't build.  Neither will apmd, but it's harder for me to
get worked up about that.

> > ---
> >  include/linux/apm_bios.h |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> Please include Signed-off-by:, as per Documentation/SubmittingPatches,
> thanks.

Blah.  Right, will remember git-format-patch -s next time.  In any
event:

Signed-off-by: Adam Jackson <[email protected]>

- ajax

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

References:
- [PATCH] apm_event{,info}_t are userspace types.
  - From: Adam Jackson <[email protected]>
- Re: [PATCH] apm_event{,info}_t are userspace types.
  - From: Andrew Morton <[email protected]>

Prev by Date: [PATCH] x86: Voluntary leave_mm before entering ACPI C3
Next by Date: Re: RFC: permit link(2) to work across --bind mounts ?
Previous by thread: Re: [PATCH] apm_event{,info}_t are userspace types.
Next by thread: Re: [PATCH] apm_event{,info}_t are userspace types.
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]