Re: [PATCH] sound/core.h: include sound/driver.h

[Marcin Slusarz <marcin.slusarz@gmail.com>]

On Mon, Dec 17, 2007 at 10:30:01AM +0100, Takashi Iwai wrote:
> At Sun, 16 Dec 2007 02:58:31 +0100,
> Marcin Slusarz wrote:
> >
> > On Fri, Dec 14, 2007 at 12:02:46PM +0100, Takashi Iwai wrote:
> > > At Sat, 8 Dec 2007 21:50:45 +0100,
> > > Marcin Ślusarz wrote:
> > > >
> > > > sound/core.h: include sound/driver.h
> > > >
> > > > include sound/driver.h in sound/core.h because core.h
> > > > uses SNDRV_CARDS (which is defined in sound/driver.h)
> > > >
> > > > Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
> > >
> > > Right now I have another (bigger) change for this include path, so
> > > this patch won't be needed any more.
> > >
> > > I applied the patches to sound/* except for this one and
> > > sound/memory.c.   Thanks!
> > >
> > Is there anything wrong with patch for rawmidi [1]?
>
> Ah, sorry, forgot to mention it.
>
> I'm still considering whether it's the best way.  The changes look
> exaggerated just for fixing sparse warnings.

It think it will let future code inspections a bit easier.
But if you have a better idea how to fix it, let me know.

Marcin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/