Re: [PATCH] atmel_serial: Split the interrupt handler

On Wed, 19 Dec 2007 14:18:18 +0100
"Remy Bohmer" <[email protected]> wrote:

> Hello Haavard,
> 
> > Hrm. We probably need to lock while updating icount. That's a problem
> > since we do that from the tx interrupt handler...and I don't suppose we
> > want to move most of the atmel_tx_chars() code into the tasklet too...?
> 
> I do not see a reason why not moving transmit to a tasklet. It is only
> time critical to read in time. If the transmit is postponed for a
> while, it will only slow down transmission, while not reading in time
> results in lost data.

Ok, let's try that. But I'm afraid this means that we can't move the
sysrq processing back into hardirq context since if we're going to do
break handling, we need to update icount.brk as well.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• References:
  • [PATCH] atmel_serial: Split the interrupt handler
    • From: Haavard Skinnemoen <[email protected]>
  • Re: [PATCH] atmel_serial: Split the interrupt handler
    • From: "Remy Bohmer" <[email protected]>
  • Re: [PATCH] atmel_serial: Split the interrupt handler
    • From: Haavard Skinnemoen <[email protected]>
  • Re: [PATCH] atmel_serial: Split the interrupt handler
    • From: "Remy Bohmer" <[email protected]>
  • Re: [PATCH] atmel_serial: Split the interrupt handler
    • From: Haavard Skinnemoen <[email protected]>
  • Re: [PATCH] atmel_serial: Split the interrupt handler
    • From: "Remy Bohmer" <[email protected]>

• Prev by Date: Re: Memory Read Error
• Next by Date: Re: INITIO scsi driver fails to work properly
• Previous by thread: Re: [PATCH] atmel_serial: Split the interrupt handler
• Next by thread: [PATCH] msi: set 'En' bit of MSI Mapping Capability
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]