Re: [PATCH 13/21] [PATCH] change bitwise operations to get a void parameter.

["H. Peter Anvin" <hpa@zytor.com>]

Glauber de Oliveira Costa wrote:
> On Dec 18, 2007 3:18 AM, Rusty Russell <rusty@rustcorp.com.au> wrote:
> > On Tuesday 18 December 2007 09:52:36 Glauber de Oliveira Costa wrote:
> > > This patch changes the bitwise operations in bitops.h to get
> > > a void pointers as a parameter. Before this patch, a lot of warnings
> > > can be seen. They're gone after it.
> > No, this is a backwards step!  These warnings are important for
> > non-arch-specific code: I fought hard to get them made into unsigned longs.
> >
> > But I'm happy for this to be applied as is, then I'll grab the git tree,
> > revert it and fix the warnings...
> Even before my processor.h patches, there are a lot of warnings caused by this.
> If Ingo does not mind getting more warnings, I can drop this patch
> entirely, and you (or someone else)
> can fix them later on.

For any code that can be executed on a bigendian processor, those are 
real bugs.  For littleendian-only code they're arguably nuisance 
warnings, but still...

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/