Re: [PATCH 7/21] [PATCH] unify common parts of processor.h

Ingo Molnar wrote:

* Glauber de Oliveira Costa <[email protected]> wrote:

This patch moves the pieces of processor_32.h and processor_64 that are equal to processor.h. Only what's exactly the same is moved around, the rest not being touched.

argh, it doesnt even build cleanly:

 In file included from include/linux/elf.h:6,
                  from include/linux/module.h:14,
                  from include/linux/crypto.h:21,
                  from arch/x86/kernel/asm-offsets_32.c:7,
                  from arch/x86/kernel/asm-offsets.c:2:
 include/asm/elf.h:286: warning: 'struct mm_struct' declared inside parameter list
 include/asm/elf.h:286: warning: its scope is only this definition or declaration, which is probably not what you want

due to zapping this bit of include/asm-x86/processor_32.h:

 -/* Forward declaration, a strange C thing */
 -struct task_struct;
 -struct mm_struct;

	Ingo

I'll test it with your config, and repost.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

---

• Follow-Ups:
  • Re: [PATCH 7/21] [PATCH] unify common parts of processor.h
    • From: Ingo Molnar <[email protected]>

• References:
  • [PATCH 0/21] Integrate processor.h
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 1/21] move tsc definitions to were they belong
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 2/21] [PATCH] get rid of _MASK flags
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 3/21] [PATCH] move desc_empty to where they belong
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 4/21] [PATCH] move load_cr3 to a common place.
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 5/21] [PATCH] unify paravirt pieces of processor.h
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 6/21] [PATCH] move the definition of set_iopl_mask to common header
    • From: Glauber de Oliveira Costa <[email protected]>
  • [PATCH 7/21] [PATCH] unify common parts of processor.h
    • From: Glauber de Oliveira Costa <[email protected]>
  • Re: [PATCH 7/21] [PATCH] unify common parts of processor.h
    • From: Ingo Molnar <[email protected]>

• Prev by Date: [PATCH] Fix crash with FLAT_MEMORY and ARCH_PFN_OFFSET != 0
• Next by Date: [PATCH v2] x86: unify module_{32|64}.h
• Previous by thread: Re: [PATCH 7/21] [PATCH] unify common parts of processor.h
• Next by thread: Re: [PATCH 7/21] [PATCH] unify common parts of processor.h
• Index(es):
  • Date
  • Thread

[Index of Archives]     [Kernel Newbies]     [Netfilter]     [Bugtraq]     [Photo]     [Stuff]     [Gimp]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Video 4 Linux]     [Linux for the blind]     [Linux Resources]