Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)

On Dec 17, 2007 9:55 AM, Eric Dumazet <[email protected]> wrote:
> -               mid = (last - first) / 2 + first;
> +       while (low <= high) {
> +               mid = (low + high) / 2;

I think you just introduced a bug. Think about what happens if
low=high=MAX_LONG/2 + 1.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Follow-Ups:
- Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)
  - From: Eric Dumazet <[email protected]>

References:
- Re: /dev/urandom uses uninit bytes, leaks user data
  - From: Herbert Xu <[email protected]>
- Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)
  - From: Linus Torvalds <[email protected]>
- Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)
  - From: Eric Dumazet <[email protected]>

Prev by Date: Re: "ip neigh show" not showing arp cache entries?
Next by Date: BUG: attempt to access beyond end of device
Previous by thread: Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)
Next by thread: Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Netfilter] [Bugtraq] [Photo] [Stuff] [Gimp] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Video 4 Linux] [Linux for the blind] [Linux Resources]